👈 Launch a Binder on branch daramayis/f-notebook/uffizzi

Hi @RRosio 👋

Any thoughts on the PR? how is it looking :)

Thank you.

Hi @daramayis thank you for the ping. We are looking to the discussion going on in JupyterLab before moving forward. I'll bring it up in the next Notebook meeting!

Thanks @daramayis for working on this!

As mentioned in #6672 (comment) we discussed this PR yesterday at the notebook weekly meeting: jupyter/notebook-team-compass#21 (comment)

While Uffizzi looks like a great service for reviewing PR, we also discussed that someone within the Jupyter Notebook team would have to take ownership of this configuration and maintain it over time.

We already use both Binder and Gitpod for working on the Notebook project in a web browser. Both have minimal setup and have been working well so far:

• https://github.com/jupyter/notebook/tree/main/binder
• https://github.com/jupyter/notebook/blob/main/.gitpod.yml

Gitpod also supports prebuilds so the dev setup can be done before someone chooses to open a workspace, helping save time: https://www.gitpod.io/docs/configure/projects/prebuilds

It looks like one advantage of using Uffizzi would be to trigger the builds automatically when new commits are pushed or when a PR is opened. This seems to overlap with what Gitpod already offers with prebuilds. Also looking at the diff of the PR the configuration involves using tools such as Docker and nginx, tools that notebook team members will likely be unfamiliar with.

Personally I won't have the bandwidth to maintain this configuration, but happy to let the PR opened longer if other contributors would like to chime in.

Hi @jtpio
Thanks for the feedback on this. I'm one of the founders at Uffizzi and can add some context.

-We also offer an internal build service which would reduce a lot of overhead by eliminating the GHA workflow file from this PR.

-Does your team / contributors use Gitpod regularly for development? For Teams that prefer local development they also tend to prefer our preview service because it's purpose designed for PR reviews and operates in a headless fashion. There's no manual steps required at any phase and unless you need logs you don't even need to interact with our UI. When someone wants to review a PR the url is right there ready to go.

-There's no way to remove docker from this PR and no immediate way to remove nginx (on our roadmap we have upgrades that would eliminate this config). Ofc you can always reach out to us for assistance with this set-up if issues arise.

If this changes your perspective please let us know and we can adjust the PR to use our internal build service. Otherwise we can close this out.

Thanks for your consideration

Hi @jtpio,

Nothing was heard, so closing the PR.